Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15311 Updated Destination Rockset to handle per-stream state #15395

Merged

Conversation

suhomud
Copy link
Contributor

@suhomud suhomud commented Aug 8, 2022

What

We want to handle per-stream properly.

How

We are adding to the output all state messages instead of only last one.

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

No user impact

@suhomud suhomud requested a review from a team as a code owner August 8, 2022 05:44
@github-actions github-actions bot added the area/connectors Connector related issues label Aug 8, 2022
@suhomud
Copy link
Contributor Author

suhomud commented Aug 8, 2022

/test connector=connectors/destination-rockset

🕑 connectors/destination-rockset https://github.com/airbytehq/airbyte/actions/runs/2815690870
✅ connectors/destination-rockset https://github.com/airbytehq/airbyte/actions/runs/2815690870
No Python unittests run

Build Passed

Test summary info:

All Passed

Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can proceed with publishing and merging without airbyte review

@suhomud
Copy link
Contributor Author

suhomud commented Aug 8, 2022

/publish connector=connectors/destination-rockset

🕑 Publishing the following connectors:
connectors/destination-rockset
https://github.com/airbytehq/airbyte/actions/runs/2817499252


Connector Did it publish? Were definitions generated?
connectors/destination-rockset

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@suhomud suhomud merged commit 9751c16 into master Aug 8, 2022
@suhomud suhomud deleted the suhomud/15311_destination_rockset_handle_per-stream_state branch August 8, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants