Fixed documentation panel width resets after resizing browser window #15454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed documentation panel unnecessary horizontal scroll Fixed main view with trial banner
github-actions
bot
added
area/platform
|
@matter-q we are working on the same thing! I was working on #15168 and started by cleaning up the components and then realized that we have a lot of overlap. I have isolated the common changes here: #15455. What I'm thinking is that these should be merged separately and this PR should resolve conflicts. |
Yes, you can merge your changes and I will resolve conflicts in my PR |
…r-resizing-browser-window # Conflicts: # airbyte-webapp/src/components/DocumentationPanel/DocumentationPanel.module.scss # airbyte-webapp/src/components/DocumentationPanel/DocumentationPanel.tsx # airbyte-webapp/src/components/Markdown/Markdown.tsx
dizel852
approved these changes
Aug 11, 2022
matter-q
deleted the
mark/documentation-panel-width-resets-after-resizing-browser-window
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #14845
How
Loom
https://www.loom.com/share/cad886ef8ef742f9b1f2b20250ea46d4