Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Amplitude: change date slice for Events stream #15506

Merged
merged 16 commits into from Aug 12, 2022

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Aug 10, 2022

What

Resolving: https://github.com/airbytehq/oncall/issues/390

How

  • changed date slice for Events stream to 1 instead of 3 to match Kube pods resource amount

🚨 User Impact 🚨

No impact is expected as the primary logic remains the same.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@bazarnov bazarnov changed the title Source Amplitud: tests on dev-cloud Source Amplitude: tests on dev-cloud Aug 10, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Aug 10, 2022
@bazarnov
Copy link
Collaborator Author

bazarnov commented Aug 10, 2022

/publish connector=connectors/source-amplitude

🕑 Publishing the following connectors:
connectors/source-amplitude
https://github.com/airbytehq/airbyte/actions/runs/2832415129


Connector Did it publish? Were definitions generated?
connectors/source-amplitude

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@bazarnov bazarnov temporarily deployed to more-secrets August 10, 2022 13:25 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets August 10, 2022 17:25 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets August 10, 2022 18:36 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Aug 10, 2022

/publish connector=connectors/source-amplitude

🕑 Publishing the following connectors:
connectors/source-amplitude
https://github.com/airbytehq/airbyte/actions/runs/2834910997


Connector Did it publish? Were definitions generated?
connectors/source-amplitude

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@bazarnov bazarnov temporarily deployed to more-secrets August 10, 2022 20:14 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Aug 10, 2022

/publish connector=connectors/source-amplitude

🕑 Publishing the following connectors:
connectors/source-amplitude
https://github.com/airbytehq/airbyte/actions/runs/2836287960


Connector Did it publish? Were definitions generated?
connectors/source-amplitude

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@bazarnov bazarnov temporarily deployed to more-secrets August 10, 2022 23:09 Inactive
@bazarnov bazarnov changed the title Source Amplitude: tests on dev-cloud 🐛 Source Amplitude: change date slice for Events stream Aug 11, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 11, 2022
@bazarnov bazarnov temporarily deployed to more-secrets August 11, 2022 19:09 Inactive
@bazarnov bazarnov changed the title 🐛 Source Amplitude: change date slice for Events stream 🐛 Source Amplitude: change date slice for events stream Aug 11, 2022
@bazarnov bazarnov changed the title 🐛 Source Amplitude: change date slice for events stream 🐛 Source Amplitude: change date slice for Events stream Aug 11, 2022
@bazarnov
Copy link
Collaborator Author

bazarnov commented Aug 12, 2022

/publish connector=connectors/source-amplitude

🕑 Publishing the following connectors:
connectors/source-amplitude
https://github.com/airbytehq/airbyte/actions/runs/2845674253


Connector Did it publish? Were definitions generated?
connectors/source-amplitude

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amplitude
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants