Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source facebook marketing (no-singer) #1552

Merged
merged 47 commits into from Jan 15, 2021
Merged

Conversation

eugene-kulak
Copy link
Contributor

@eugene-kulak eugene-kulak commented Jan 6, 2021

Contributor Checklist

Thanks for contributing to Airbyte! Please complete the following items in order so we can review your PR.

  • Followed all the instructions in the locally generated checklist and your connector is functional & ready for review
  • Ran the standard test suite locally via ./gradlew :airbyte-integrations:connectors:source-<your_source_name>:standardSourceTestPython and pasted the summarized output as a comment in this PR

Reviewer Pre-merge Checklist

  • Finished iterating with the PR author on the code*
  • Created a branch off master to merge this PR into*
  • Inject the credentials in CI via ./tools/integrations/ci_credentials.sh and .github/workflows/test-command.yml*
  • Added the credentials for this integration to Github secrets
  • Run standard tests on this branch by commenting /test connector=<name>*
  • Add entry in airbyte-config/init/src/main/resources/seed/source_definitions.yaml to use the new source in Airbyte core
  • Deployed the connector to Dockerhub via ./tools/integrations/manage.sh publish airbyte-integrations/connectors/source-<name>

Documentation

  • Add docs in docs/integrations/sources/ folder in line with the documentation template found in docs/contributing-to-airbyte/templates/integration-documentation-template.md.
  • Add link to create docs file to docs/SUMMARY.md
  • Include a link to the documentation in the README.md

@eugene-kulak
Copy link
Contributor Author

eugene-kulak commented Jan 6, 2021

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/467227013
❌ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/467227013

@eugene-kulak
Copy link
Contributor Author

looks like API Token expired, we need to generate another one

@eugene-kulak
Copy link
Contributor Author

eugene-kulak commented Jan 7, 2021

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/468358631
❌ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/468358631

@eugene-kulak
Copy link
Contributor Author

eugene-kulak commented Jan 13, 2021

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/483464522
✅ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/483464522

@eugene-kulak eugene-kulak linked an issue Jan 14, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Facebook connector to support API v9
3 participants