Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 disable ssh tunnel idle timeout #15635

Merged
merged 1 commit into from Aug 29, 2022
Merged

Conversation

philippeboyd
Copy link
Contributor

@philippeboyd philippeboyd commented Aug 13, 2022

What

Closes #14459 and other future potential issues whenn using an SSH tunnel.

When streaming a long request through an SSH tunnel, the tunnel will timeout after 10 minutes according to Apache SSHD's CoreModuleProperties IDLE_TIMEOUT

How

This PR disables the IDLE_TIMEOUT by settting it to 0

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@philippeboyd philippeboyd requested a review from a team as a code owner August 13, 2022 23:52
@philippeboyd philippeboyd changed the title feat: disable ssh tunnel idle timeout 🎉 disable ssh tunnel idle timeout Aug 15, 2022
@philippeboyd
Copy link
Contributor Author

/test connector=connectors/source-mssql

@philippeboyd
Copy link
Contributor Author

@sajarin do you think you could take a look at this, please? I'm suprised no one ever flagged this issue with the SSH tunnel

@marcosmarxm
Copy link
Member

marcosmarxm commented Aug 15, 2022

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2862489714
❌ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2862489714
🐛 https://gradle.com/s/unzzlxguyamwo

Build Failed

Test summary info:

Could not find result summary

@philippeboyd
Copy link
Contributor Author

@marcosmarxm thanks for the test connector

I'm aware this PR is related to all connectors using SSH tunnel. Do you guys have an easy way to update the semantic version of all associated connectors via a gradle command?

@marcosmarxm
Copy link
Member

I'm aware this PR is related to all connectors using SSH tunnel. Do you guys have an easy way to update the semantic version of all associated connectors via a gradle command?

No :(

@philippeboyd
Copy link
Contributor Author

@marcosmarxm damn, so the best course of action is for me to update all associated jdbc connectors or do I leave that to the @jdbc-connectors team?

@marcosmarxm
Copy link
Member

@tuliren do you mind checking this PR?

@marcosmarxm
Copy link
Member

@philippeboyd sorry the delay reviewing this, I requested to connector team to take a look.

@grishick
Copy link
Contributor

@rodireich since you are in the depth of testing SSL and will be updating versions of DB connectors, please review, tests, and merge this PR after you merge your SSL changes. It looks like you may have to bump versions and update changelogs of all DB connectors when publishing this PR.

Copy link
Contributor

@grishick grishick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs to be tested

@marcosmarxm
Copy link
Member

Thanks @grishick!

@grishick grishick merged commit aceaf28 into airbytehq:master Aug 29, 2022
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Source MSSQL] - SQL Server returned an incomplete response. The connection has been closed.
5 participants