New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 disable ssh tunnel idle timeout #15635
Conversation
/test connector=connectors/source-mssql |
@sajarin do you think you could take a look at this, please? I'm suprised no one ever flagged this issue with the SSH tunnel |
/test connector=connectors/source-mssql
Build FailedTest summary info:
|
@marcosmarxm thanks for the I'm aware this PR is related to all connectors using SSH tunnel. Do you guys have an easy way to update the semantic version of all associated connectors via a gradle command? |
No :( |
@marcosmarxm damn, so the best course of action is for me to update all associated jdbc connectors or do I leave that to the @jdbc-connectors team? |
@tuliren do you mind checking this PR? |
6ac1ae4
to
99464ad
Compare
@philippeboyd sorry the delay reviewing this, I requested to connector team to take a look. |
@rodireich since you are in the depth of testing SSL and will be updating versions of DB connectors, please review, tests, and merge this PR after you merge your SSL changes. It looks like you may have to bump versions and update changelogs of all DB connectors when publishing this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but needs to be tested
Thanks @grishick! |
What
Closes #14459 and other future potential issues whenn using an SSH tunnel.
When streaming a long request through an SSH tunnel, the tunnel will timeout after 10 minutes according to Apache SSHD's CoreModuleProperties IDLE_TIMEOUT
How
This PR disables the IDLE_TIMEOUT by settting it to
0
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.