Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source RKI (Robert Koch-Institut): add message when no data available #15667

Merged
merged 6 commits into from
Aug 25, 2022

Conversation

Zawar92
Copy link
Contributor

@Zawar92 Zawar92 commented Aug 15, 2022

What

In the connector source-rki-covid there are times when data is not available for a certain date. In order to avoid error condition added.

Related Issue

How

Adding the message when data not available for specific date.

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@marcosmarxm
Copy link
Member

@Zawar92 can you check the other files changes in the PR?

@marcosmarxm
Copy link
Member

@Zawar92 please check your commit. You're changing other files besides what you're describing in the PR.

@Zawar92
Copy link
Contributor Author

Zawar92 commented Aug 22, 2022

@marcosmarxm
I am just changing two files.

  1. source.py where i am adding the error condition.
  2. unit test files related to that.

@marcosmarxm
Copy link
Member

@marcosmarxm I am just changing two files.

  1. source.py where i am adding the error condition.
  2. unit test files related to that.

not what your PR is doing. Check the files changed here in Github web

@Zawar92
Copy link
Contributor Author

Zawar92 commented Aug 22, 2022

Yes those files must have changed when I took the new pull from main. Then executed gradlew for:

  1. airbytePythonFormat
  2. integrationTest
  3. build
  4. format

@marcosmarxm
Copy link
Member

You can run the command and remove the other files OR run ./gradlew --no-daemon :airbyte-integrations:connectors:<connector_name>:airbytePythonFormat

@marcosmarxm
Copy link
Member

marcosmarxm commented Aug 25, 2022

/test connector=connectors/source-rki-covid

🕑 connectors/source-rki-covid https://github.com/airbytehq/airbyte/actions/runs/2923784873
❌ connectors/source-rki-covid https://github.com/airbytehq/airbyte/actions/runs/2923784873
🐛 https://gradle.com/s/aq5ggfqm2tubi

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_additional_properties_is_true[inputs0] - ...
=================== 1 failed, 27 passed in 76.68s (0:01:16) ====================

@marcosmarxm
Copy link
Member

marcosmarxm commented Aug 25, 2022

/test connector=connectors/source-rki-covid

🕑 connectors/source-rki-covid https://github.com/airbytehq/airbyte/actions/runs/2923880380
✅ connectors/source-rki-covid https://github.com/airbytehq/airbyte/actions/runs/2923880380
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_rki_covid/__init__.py       2      0   100%
source_rki_covid/source.py       253     67    74%
--------------------------------------------------
TOTAL                            255     67    74%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1322    463    65%

Build Passed

Test summary info:

All Passed

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 25, 2022
@marcosmarxm marcosmarxm requested review from marcosmarxm and removed request for a team August 25, 2022 04:39
@marcosmarxm marcosmarxm changed the title Update Source: RKI (Robert Koch-Institut) Covid Public API 🐛 Source RKI (Robert Koch-Institut): add message when no data available Aug 25, 2022
@marcosmarxm marcosmarxm merged commit 2c89185 into airbytehq:master Aug 25, 2022
rodireich pushed a commit that referenced this pull request Aug 25, 2022
…le (#15667)

* updated parse_response with a message.

* updated test and executed gradlew

* updated unit tests.

* applied gradlew with no daemon for airbyte python format

* change addProperties to true

* update docs

Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants