Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Source Chargebee: fix schema field type issue #15743

Merged

Conversation

lazebnyi
Copy link
Collaborator

What

#14796 - Source: Chargebee schema field type issue

How

Changed field type in schema from integer to number.

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 17, 2022
@lazebnyi lazebnyi linked an issue Aug 17, 2022 that may be closed by this pull request
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 19, 2022

/test connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/2886823268
❌ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/2886823268
🐛 https://gradle.com/s/ot7fwpucexxke

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_backward_compatibility.py::test_validate_previous_configs[Nested level: Narrowing a field enum should fail.]
	 
	 Results (262.69s):
	 �[32m     304 passed�[0m
	 �[31m       1 failed�[0m
	          - �[36m�[0mtest_backward_compatibility.py�[0m:965 �[31mtest_validate_previous_configs[Nested level: Narrowing a field enum should fail.]�[0m
	 /actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/source-acceptance-test/.venv/lib/python3.9/site-packages/coverage/control.py:788: CoverageWarning: No data was collected. (no-data-collected)
	   self._warn("No data was collected.", slug="no-data-collected")

> Task :airbyte-integrations:bases:source-acceptance-test:_unitTestCoverage FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4/userguide/command_line_interface.html#sec:command_line_warnings
42 actionable tasks: 29 executed, 13 up-to-date

Publishing build scan...
https://gradle.com/s/ot7fwpucexxke

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 19, 2022

/test connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/2891054043
✅ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/2891054043
Python tests coverage:

Name                                Stmts   Miss  Cover
-------------------------------------------------------
source_chargebee/source.py             25      0   100%
source_chargebee/__init__.py            2      0   100%
source_chargebee/streams.py           159     27    83%
source_chargebee/rate_limiting.py      19      7    63%
-------------------------------------------------------
TOTAL                                 205     34    83%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1321    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:235: Backward compatibility tests are disabled for version 0.1.12.
======================== 28 passed, 1 skipped in 53.97s ========================

@lazebnyi lazebnyi marked this pull request as ready for review August 19, 2022 17:18
@lazebnyi lazebnyi removed the request for review from midavadim August 19, 2022 17:18
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 19, 2022

/publish connector=connectors/source-chargebee

🕑 Publishing the following connectors:
connectors/source-chargebee
https://github.com/airbytehq/airbyte/actions/runs/2891327838


Connector Did it publish? Were definitions generated?
connectors/source-chargebee

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@lazebnyi lazebnyi merged commit 695fef1 into master Aug 19, 2022
@lazebnyi lazebnyi deleted the lazebnyi/14796-source-chargebee-fix-schema-field-type-issue branch August 19, 2022 18:35
rodireich pushed a commit that referenced this pull request Aug 25, 2022
* Updated transaction schema field type

* Bumped version

* Updated PR number

* Fix acceptance tests

* Skip backward_compatibility_tests_config

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/chargebee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source: Chargebee 0.1.12
3 participants