Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourse Zendesk Talk: OAuth2.0 and unittests #15764

Merged
merged 15 commits into from
Sep 5, 2022

Conversation

roman-yermilov-gl
Copy link
Contributor

@roman-yermilov-gl roman-yermilov-gl commented Aug 18, 2022

What

  • Oauth2.0 support
  • unittest coverage 90%

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

User can choose of two types of authentication. API token and OAuth2.0 are supported.

Updating a connector

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@CLAassistant
Copy link

CLAassistant commented Aug 18, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 18, 2022
@roman-yermilov-gl roman-yermilov-gl linked an issue Aug 19, 2022 that may be closed by this pull request
@roman-yermilov-gl roman-yermilov-gl changed the title Sourse Zendesk Talk: Sourse Zendesk Talk: OAuth2.0 and unittests Aug 19, 2022
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Aug 19, 2022

/test connector=connectors/source-zendesk-talk

🕑 connectors/source-zendesk-talk https://github.com/airbytehq/airbyte/actions/runs/2889938157
✅ connectors/source-zendesk-talk https://github.com/airbytehq/airbyte/actions/runs/2889938157
Python tests coverage:

Name                              Stmts   Miss  Cover
-----------------------------------------------------
source_zendesk_talk/__init__.py       2      0   100%
source_zendesk_talk/streams.py      139     11    92%
source_zendesk_talk/source.py        40      6    85%
-----------------------------------------------------
TOTAL                               181     17    91%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1321    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:235: Backward compatibility tests are disabled for version 0.1.3.
=================== 28 passed, 1 skipped in 66.13s (0:01:06) ===================

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 19, 2022
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets August 19, 2022 18:14 Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets August 19, 2022 18:20 Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets August 19, 2022 18:23 Inactive
@roman-yermilov-gl roman-yermilov-gl self-assigned this Aug 22, 2022
@lazebnyi lazebnyi removed the request for review from grubberr August 29, 2022 13:49
@YowanR
Copy link
Contributor

YowanR commented Aug 30, 2022

Assigning this one to @alafanechere on the Airbyte side for review as @Phlair is OOO. Thank you!

@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets September 1, 2022 17:51 Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets September 1, 2022 18:30 Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets September 1, 2022 18:50 Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets September 1, 2022 18:56 Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets September 1, 2022 20:30 Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets September 5, 2022 12:25 Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets September 5, 2022 13:37 Inactive
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Sep 5, 2022

/publish connector=connectors/source-zendesk-talk

🕑 Publishing the following connectors:
connectors/source-zendesk-talk
https://github.com/airbytehq/airbyte/actions/runs/2994044332


Connector Did it publish? Were definitions generated?
connectors/source-zendesk-talk

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@bazarnov bazarnov temporarily deployed to more-secrets September 5, 2022 14:30 Inactive
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Sep 5, 2022

/publish connector=connectors/source-zendesk-talk

🕑 Publishing the following connectors:
connectors/source-zendesk-talk
https://github.com/airbytehq/airbyte/actions/runs/2994529047


Connector Did it publish? Were definitions generated?
connectors/source-zendesk-talk

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@midavadim midavadim merged commit 5853d52 into master Sep 5, 2022
@midavadim midavadim deleted the ryermilov/source-zendesk-talk branch September 5, 2022 16:14
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
* Sourse Zendesk Talk:

- Oauth2.0 support
- unittest coverage 90%

* Source Zendesk Talk: update documentation

* Source Zendesk Talk: update changelog

* Source Zendesk Talk: update field description

* Source Zendesk Talk: fix documentation caption

* Source Zendesk Talk: fix spec, improve tests

* Source Zendesk Talk: remove Makefile

* Source Zendesk Talk: fix tests

* Source Zendesk Talk: fix tests

* Source Zendesk Talk: acceptance-test-config.yml test commit

* Source Zendesk Talk: acceptance-test-config.yml test commit

* Source Zendesk Talk: fix spec, add config to acceptance tests

* added oauth java test

* auto-bump connector version [ci skip]

Co-authored-by: Oleksandr Bazarnov <oleksandr.bazarnov@globallogic.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* Sourse Zendesk Talk:

- Oauth2.0 support
- unittest coverage 90%

* Source Zendesk Talk: update documentation

* Source Zendesk Talk: update changelog

* Source Zendesk Talk: update field description

* Source Zendesk Talk: fix documentation caption

* Source Zendesk Talk: fix spec, improve tests

* Source Zendesk Talk: remove Makefile

* Source Zendesk Talk: fix tests

* Source Zendesk Talk: fix tests

* Source Zendesk Talk: acceptance-test-config.yml test commit

* Source Zendesk Talk: acceptance-test-config.yml test commit

* Source Zendesk Talk: fix spec, add config to acceptance tests

* added oauth java test

* auto-bump connector version [ci skip]

Co-authored-by: Oleksandr Bazarnov <oleksandr.bazarnov@globallogic.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-talk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Zendesk Talk: support oauth
10 participants