-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sourse Zendesk Talk: OAuth2.0 and unittests #15764
Conversation
/test connector=connectors/source-zendesk-talk
Build PassedTest summary info:
|
airbyte-integrations/connectors/source-zendesk-talk/unit_tests/test_source.py
Outdated
Show resolved
Hide resolved
Assigning this one to @alafanechere on the Airbyte side for review as @Phlair is OOO. Thank you! |
airbyte-integrations/connectors/source-zendesk-talk/acceptance-test-config.yml
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-talk/acceptance-test-config.yml
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-talk/source_zendesk_talk/spec.json
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-talk/unit_tests/test_streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-talk/unit_tests/test_streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-talk/unit_tests/test_streams.py
Show resolved
Hide resolved
airbyte-oauth/src/main/java/io/airbyte/oauth/flows/ZendeskTalkOAuthFlow.java
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-talk/source_zendesk_talk/spec.json
Outdated
Show resolved
Hide resolved
- Oauth2.0 support - unittest coverage 90%
810e76c
to
d1dc4ab
Compare
/publish connector=connectors/source-zendesk-talk
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/source-zendesk-talk
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* Sourse Zendesk Talk: - Oauth2.0 support - unittest coverage 90% * Source Zendesk Talk: update documentation * Source Zendesk Talk: update changelog * Source Zendesk Talk: update field description * Source Zendesk Talk: fix documentation caption * Source Zendesk Talk: fix spec, improve tests * Source Zendesk Talk: remove Makefile * Source Zendesk Talk: fix tests * Source Zendesk Talk: fix tests * Source Zendesk Talk: acceptance-test-config.yml test commit * Source Zendesk Talk: acceptance-test-config.yml test commit * Source Zendesk Talk: fix spec, add config to acceptance tests * added oauth java test * auto-bump connector version [ci skip] Co-authored-by: Oleksandr Bazarnov <oleksandr.bazarnov@globallogic.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
* Sourse Zendesk Talk: - Oauth2.0 support - unittest coverage 90% * Source Zendesk Talk: update documentation * Source Zendesk Talk: update changelog * Source Zendesk Talk: update field description * Source Zendesk Talk: fix documentation caption * Source Zendesk Talk: fix spec, improve tests * Source Zendesk Talk: remove Makefile * Source Zendesk Talk: fix tests * Source Zendesk Talk: fix tests * Source Zendesk Talk: acceptance-test-config.yml test commit * Source Zendesk Talk: acceptance-test-config.yml test commit * Source Zendesk Talk: fix spec, add config to acceptance tests * added oauth java test * auto-bump connector version [ci skip] Co-authored-by: Oleksandr Bazarnov <oleksandr.bazarnov@globallogic.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
User can choose of two types of authentication. API token and OAuth2.0 are supported.
Updating a connector
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here