Repository navigation
Handle invalid numeric values in JDBC source - #1588
Merged
Merged
Conversation
…faultSchedulerJobClient.java
Sherif A. Nada (sherifnada)
requested review from
Charles (cgardens),
Jared Rhizor (jrhizor) and
Michel Tricot (michel-tricot)
January 8, 2021 18:27
Contributor
|
I am afraid that this is adding transformation logic to the source. What would be another option? |
Sherif A. Nada (sherifnada)
requested review from
Charles (cgardens) and
Jared Rhizor (jrhizor)
and removed request for
Charles (cgardens),
Jared Rhizor (jrhizor) and
Michel Tricot (michel-tricot)
January 13, 2021 19:29
Jared Rhizor (jrhizor)
approved these changes
Jan 13, 2021
Jared Rhizor (jrhizor)
left a comment
Jared Rhizor (jrhizor)
left a comment
Contributor
There was a problem hiding this comment.
It's unfortunate that NaN/null/infinity will look the same on the destination, but I can't think of a better way right now.
This behavior should be added to our data types documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
NaN and infinity are not supported in JSON schema, but are allowed values in various Postgres numeric types . So we force them into null at the DB level.
Releasing this now to fix a bug that a user is having. But we'll want to have tests like this for every data type's edge cases. This is coming in a later PR.