CDK: Fix regression in _checkpoint_state arg

[grubberr]

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Fix incorrect use of self._checkpoint_state
we need to pass stream_state because stream_instance.state can be undefined

[sherifnada]

@grubberr can you edit the PR description to include a description of the problem, an example, and why this code change fixes it?

[edgao]

@sherifnada I think the context is https://github.com/airbytehq/oncall/issues/466

I don't think I can competently review this PR, I have basically no experience with CDK internals; removing my review request. LMK if there's anything I can do to help get this deployed though.

couple drive-by comments while I'm here:

• is the plan to publish source-amplitude as part of this pr (and/or in a followup pr)?
• is it possible to add a unit test to catch whatever the problem was?

[grubberr]

/publish-cdk dry-run=true

❌ https://github.com/airbytehq/airbyte/actions/runs/2962320722

[grubberr]

FYI @sherifnada @lazebnyi @bazarnov @davydov-d @roman-yermilov-gl

New pydantic released 1.10.0 and it's behaviour changed for const keyword

from pydantic import BaseModel, Field

class Choice1(BaseModel):
    field = Field("option1", const=True)

pydantic==1.9.2

{
    "properties": {
        "field": {"title": "Field", "const": "option1", "type": "string"}
    }
}

pydantic==1.10.0

{
    "properties": {
        "field": {"title": "Field", "default": "option1", "const": "option1", "type": "string"}
    }
}

Maybe we would need to return default keyword to common properties in spec again

https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py#L122

[davydov-d]

FYI @sherifnada @lazebnyi @bazarnov @davydov-d @roman-yermilov-gl

New pydantic released 1.10.0 and it's behaviour changed for const keyword

from pydantic import BaseModel, Field

class Choice1(BaseModel):
    field = Field("option1", const=True)

pydantic==1.9.2

{
    "properties": {
        "field": {"title": "Field", "const": "option1", "type": "string"}
    }
}

pydantic==1.10.0

{
    "properties": {
        "field": {"title": "Field", "default": "option1", "const": "option1", "type": "string"}
    }
}

Maybe we would need to return default keyword to common properties in spec again

https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py#L122

As an option we could pin pydantic version not to change/during the change will be made to all the models in the connectors

[sherifnada]

Yeah we can’t upgrade pydantic or it will cause issues.

[grubberr]

SAT updates for new pydantic #16172

[grubberr]

@sherifnada I have pinned pydantic~=1.9.2
we can put this PR #16172 on-hold until we decide how to be with new pydantic

[grubberr]

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/2965915354
✅ https://github.com/airbytehq/airbyte/actions/runs/2965915354

[grubberr]

/publish-cdk dry-run=false

[grubberr]

/publish-cdk dry-run=false

[grubberr]

/publish-cdk dry-run=false

[grubberr]

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/2966494773
✅ https://github.com/airbytehq/airbyte/actions/runs/2966494773