🪟 🔧 Publish webapp storybook to chromatic in CI #16169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundito
force-pushed
the
edmundito/storybook-to-chromatic-workflow
branch
from
43ddc2b
to
be126fc
Compare
edmundito
force-pushed
the
edmundito/storybook-to-chromatic-workflow
branch
2 times, most recently
from
ce486b2
to
1f8999b
Compare
…correct github token to step
edmundito
force-pushed
the
edmundito/storybook-to-chromatic-workflow
branch
from
1f8999b
to
c5378fb
Compare
davinchia
reviewed
Sep 7, 2022
| runs-on: ${{ needs.start-frontend-runner.outputs.label }} | ||
| steps: | ||
| - name: Checkout Airbyte | ||
| uses: actions/checkout@v2 | ||
| with: |
There was a problem hiding this comment.
It's for Chromatic to be able to track the history:
Chromatic supports the latest versions of the actions/checkout (i.e., versions 2 and 3). Both of them come with a caveat. They will only retrieve a single commit without any additional history. Chromatic needs the full Git history to keep track of changes in your repository.
https://www.chromatic.com/docs/github-actions#support-for-codeactionscheckoutv2code-and-above
davinchia
approved these changes
Sep 7, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Add Publish to storybook step in webapp gradle workflow * Set fetch-dept to 0 for airbyte webapp build * Fix typo in chromatic config * Fix typo when you've been writing too much css * Fix storybook build path in gradle workflow * Use full path in chromatic action * Try another path configuration for chromatic workflow action * Use label ot token in storybook deploy * Back to github_token * Move Storybook deploy to separate job * Fix run command in publish storybook workflow * Rollback publish storybook as separate step from build-frontend, add correct github token to step * Let the chromatic step build the storybook * Restore storybookBuildDir on publish to chromatic step * Add exitOnceUploaded to chromatic action
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Add Publish to storybook step in webapp gradle workflow * Set fetch-dept to 0 for airbyte webapp build * Fix typo in chromatic config * Fix typo when you've been writing too much css * Fix storybook build path in gradle workflow * Use full path in chromatic action * Try another path configuration for chromatic workflow action * Use label ot token in storybook deploy * Back to github_token * Move Storybook deploy to separate job * Fix run command in publish storybook workflow * Rollback publish storybook as separate step from build-frontend, add correct github token to step * Let the chromatic step build the storybook * Restore storybookBuildDir on publish to chromatic step * Add exitOnceUploaded to chromatic action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #14846
Adds step to publish storybook to chromatic in CI
How
Uses the @chromaui/action Github action to publish the storybook during the "Frontend: Build" CI workflow step
Tests