Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add airbyte-metrics to list of charts to be packaged #16270

Conversation

milesarmstrong
Copy link
Contributor

What

Ensure we package the new airbyte-metrics chart before we try to package the main chart.

A follow up to #16166

Fixes the failure seen in a43c098

@milesarmstrong milesarmstrong changed the title Add airbyte-metrics to list of charts to be packaged Fix: Add airbyte-metrics to list of charts to be packaged Sep 2, 2022
@milesarmstrong
Copy link
Contributor Author

@xpuska513 Thanks for approving / merging #16166

This PR fixes the packaging of the new Helm chart that I missed in the previous PR.

@xpuska513
Copy link
Contributor

I already fixed this one in my #16131

@milesarmstrong
Copy link
Contributor Author

@xpuska513 thanks, however would you mind merging this PR first? It seems like yours will take a little while to get reviewed/merged, and Helm chart releases are failing on master until this is fixed (also it's blocking us at Duffel as we need the metrics chart in place!)

@marcosmarxm
Copy link
Member

@xpuska513 do you think we can merge this contribution?

@xpuska513
Copy link
Contributor

Sure, don't see problem at all

@xpuska513
Copy link
Contributor

Just make sure you started https://github.com/airbytehq/airbyte/actions/workflows/publish-helm-charts.yml so the chart will be released

@xpuska513
Copy link
Contributor

Started after merging ofc 😉

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcosmarxm marcosmarxm merged commit 5ccea65 into airbytehq:master Sep 5, 2022
@milesarmstrong
Copy link
Contributor Author

milesarmstrong commented Sep 6, 2022

@xpuska513 @marcosmarxm thanks for the merge! Could one of you run the release action please? Looks like it was cancelled last night 😕?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants