-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉Source Sendgrid: increase unit test coverage at least 90% #16332
Conversation
/test connector=connectors/source-sendgrid
Build FailedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the requests_mock
should be the part of setup.py
, since unit_tests require it.
https://github.com/airbytehq/airbyte/blob/lazebnyi/source-sendgrid-coverage-unittest/airbyte-integrations/connectors/source-sendgrid/setup.py
/test connector=connectors/source-sendgrid
Build FailedTest summary info:
|
/test connector=connectors/source-sendgrid
Build FailedTest summary info:
|
/test connector=connectors/source-sendgrid
Build PassedTest summary info:
|
…#16332) * Added unit tests * Updated test name * Updated setup * Fix requirements * Updated release stage * Updated expected_records
…#16332) * Added unit tests * Updated test name * Updated setup * Fix requirements * Updated release stage * Updated expected_records
What
#16331
How
Added unit tests
Pre-merge Checklist
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog example