Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source: Instagram - Use latest CDK version #16340

Merged
merged 4 commits into from
Sep 6, 2022
Merged

Conversation

pedroslopez
Copy link
Contributor

@pedroslopez pedroslopez commented Sep 5, 2022

What

The instagram source v0.1.9 was released a year ago (sep 30, 2021) so it does not have our latest CDK improvements, such as airbyte trace messages. This means that errors from instagram are not being reported to sentry.

closes https://github.com/airbytehq/airbyte-cloud/issues/2635

How

Update sentry to use the latest version of the CDK.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 5, 2022
@pedroslopez
Copy link
Contributor Author

pedroslopez commented Sep 5, 2022

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/2996243933
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/2996243933
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/api.py           59      5    92%
source_instagram/source.py        38     11    71%
source_instagram/streams.py      207     90    57%
source_instagram/common.py        36     22    39%
--------------------------------------------------
TOTAL                            342    128    63%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/source.py        38      1    97%
source_instagram/common.py        36      3    92%
source_instagram/streams.py      207     23    89%
source_instagram/api.py           59      7    88%
--------------------------------------------------
TOTAL                            342     34    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1322    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 26 passed, 1 skipped in 321.70s (0:05:21) ===================

@pedroslopez
Copy link
Contributor Author

pedroslopez commented Sep 5, 2022

/publish connector=connectors/source-instagram

🕑 Publishing the following connectors:
connectors/source-instagram
https://github.com/airbytehq/airbyte/actions/runs/2996374847


Connector Did it publish? Were definitions generated?
connectors/source-instagram

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@pedroslopez pedroslopez merged commit ec70b32 into master Sep 6, 2022
@pedroslopez pedroslopez deleted the pedroslopez/bump-ig-cdk branch September 6, 2022 00:46
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/instagram
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants