Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add airbyte_secret field in example #16374

Merged
merged 1 commit into from
Sep 7, 2022
Merged

doc: add airbyte_secret field in example #16374

merged 1 commit into from
Sep 7, 2022

Conversation

alafanechere
Copy link
Contributor

What

In the Define inputs section of Python CDK: Creating a HTTP API Source we did not show that the access_token field should be considered as secret.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 6, 2022
teallarson
teallarson approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves what is mentioned in the description.

We probably want to call out on this page that secrets need to be handled using airbyte_type: secret so folks are aware, but maybe that's a separate PR.

@alafanechere alafanechere merged commit e253b98 into master Sep 7, 2022
@alafanechere alafanechere deleted the docs/airbyte-secret-in-example branch September 7, 2022 07:29
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Sep 12, 2022
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@alafanechere @robbinhan
doc: add airbyte_secret field in example (airbytehq#16374)
c7fe542
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@alafanechere @jhammarstedt
doc: add airbyte_secret field in example (airbytehq#16374)
1f2850a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teallarson teallarson teallarson approved these changes

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alafanechere @teallarson