New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉Source-cockroachdb: added custom JDBC parameters field #16394
🎉Source-cockroachdb: added custom JDBC parameters field #16394
Conversation
NOTE
|
/test connector=connectors/source-cockroachdb
Build PassedTest summary info:
|
/test connector=connectors/source-cockroachdb-strict-encrypt
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. we can proceed with publishing and merging without airbyte review
/publish connector=connectors/source-cockroachdb
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/source-cockroachdb-strict-encrypt
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
We want to have an option to pass custom jdbc args to a connection string
How
Added support for CockroachDB Source to take in a JDBC URL Params input to specify any additional JDBC parameters for the connection.
🚨 User Impact 🚨
This is an optional field, so no breaking changes expected
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.