Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🐛 Prevent false triggers of "some streams have changed" modal #16443

Merged
merged 2 commits into from
Sep 8, 2022
Merged

🪟 🐛 Prevent false triggers of "some streams have changed" modal #16443

merged 2 commits into from
Sep 8, 2022

Conversation

teallarson
Copy link
Contributor

@teallarson teallarson commented Sep 8, 2022 •
edited

What

Closes #16012

Previously, we would sometimes falsely trigger the "some streams have changed" modal when saving this form because we were comparing sorted data against unsorted data.

Now, we sort both arrays of streams when comparing them.

How

Sorting both arrays of streams (form values and values received from the backend) when comparing.

@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Sep 8, 2022
@teallarson teallarson marked this pull request as ready for review September 8, 2022 15:25
@teallarson teallarson requested a review from a team as a code owner September 8, 2022 15:25
@teallarson teallarson changed the title 🪟 🐛 🪟 🐛 Prevent false triggers of "some streams have changed" modal Sep 8, 2022
krishnaglick
krishnaglick approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is an intermittent issue, this solution LGTM but we can only test by the absence of further reports as far as I know.

@teallarson teallarson merged commit 8866c8e into master Sep 8, 2022
@teallarson teallarson deleted the teal/stream-config-change-modal-bug branch September 8, 2022 16:47
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Sep 12, 2022
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@teallarson @robbinhan
🪟 🐛 Prevent false triggers of "some streams have changed" modal (airb…
d93c197 
…ytehq#16443)

* add missing sort

* sort both for good measure
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@teallarson @jhammarstedt
🪟 🐛 Prevent false triggers of "some streams have changed" modal (airb…
52d8f1f 
…ytehq#16443)

* add missing sort

* sort both for good measure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnaglick krishnaglick krishnaglick approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Stream configuration changed" modal may appear for some streams even when the data has not changed
2 participants
@teallarson @krishnaglick