Exclude webapp from spotless styling #16455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
eslint and prettier are only configured in airbyte-webapp. We should copy those over. Or symlink them? |
|
@krishnaglick it looks like we already have some cypress-specific eslint configuration in airbyte-webapp-e2e-tests: airbyte/airbyte-webapp-e2e-tests/package.json Lines 11 to 22 in f81c5aa So I don't think we need to add more eslint configuration there. But I have added prettier to that module and symlinked the .prettierrc.js files as you recommended, and I ran prettier on that module and committed the changes to this PR
|
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* exclude webapp from spotless styling * also exclude airbyte-webapp-e2e-tests * add comma * add prettier to airbyte-webapp-e2e-tests * run prettier on airbyte-webapp-e2e-tests
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* exclude webapp from spotless styling * also exclude airbyte-webapp-e2e-tests * add comma * add prettier to airbyte-webapp-e2e-tests * run prettier on airbyte-webapp-e2e-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR excludes the airbyte-webapp module from spotless styling. This module has its own auto-formatting plugins (e.g. prettier) and therefore does not also need spotless to run on it.
Having both auto-formatters running on this module can lead to inconsistencies and broken builds, such as the situation described in this PR: #16423
How
Excludes the airbyte-webapp module from the spotless target in the top-level build.gradle.
馃毃 User Impact 馃毃
No user impact.