Populate and read from SyncStats table #16476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 64d024d.
github-actions
bot
added
area/platform
gosusnp
previously requested changes
Sep 8, 2022
| .set(SYNC_STATS.ATTEMPT_ID, attemptId) | ||
| .set(SYNC_STATS.BYTES_EMITTED, syncStats.getBytesEmitted()) | ||
| .set(SYNC_STATS.RECORDS_EMITTED, syncStats.getRecordsEmitted()) | ||
| .set(SYNC_STATS.RECORDS_COMMITTED, syncStats.getRecordsEmitted()) |
| @@ -249,14 +252,34 @@ void testWriteOutput() throws IOException { | |||
| final long jobId = jobPersistence.enqueueJob(SCOPE, SPEC_JOB_CONFIG).orElseThrow(); | |||
| final int attemptNumber = jobPersistence.createAttempt(jobId, LOG_PATH); | |||
| final Job created = jobPersistence.getJob(jobId); | |||
| final JobOutput jobOutput = new JobOutput().withOutputType(JobOutput.OutputType.DISCOVER_CATALOG); | |||
| final SyncStats syncStats = | |||
| new SyncStats().withBytesEmitted(100L).withRecordsEmitted(10L).withRecordsCommitted(10L).withDestinationStateMessagesEmitted(1L) | |||
There was a problem hiding this comment.
Different values for recordsEmitted and recordsCommitted would have caught the typo.
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
- Populate sync stats table when job is complete - Method to read from sync stats table
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
- Populate sync stats table when job is complete - Method to read from sync stats table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR does a few things around the SyncStats table:
writeOutputmethod in DefaultJobPersistence.java. Because we are continuing to store sync stats in the JSON blob, I put the write to sync_stats inside the transaction that writes to the sync output to the attempts table. Once we move SyncStats completely out of that JSON blob, we should have a separate method for writing to the sync stats table.Recommended reading order