Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination RabbitMQ: Make password marked as airbyte_secret #16528

Merged
merged 3 commits into from Sep 9, 2022

Conversation

yurii-bidiuk
Copy link
Contributor

@yurii-bidiuk yurii-bidiuk commented Sep 9, 2022

What

Fixes #16420
Screenshot from 2022-09-09 13-21-06

How

Added airbyte_secret to spec

Recommended reading order

  1. spec.json

🚨 User Impact 🚨

There are no breaking changes

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 9, 2022
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Sep 9, 2022

/test connector=connectors/destination-rabbitmq

🕑 connectors/destination-rabbitmq https://github.com/airbytehq/airbyte/actions/runs/3021616366
✅ connectors/destination-rabbitmq https://github.com/airbytehq/airbyte/actions/runs/3021616366
Python tests coverage:

Name                                  Stmts   Miss  Cover
---------------------------------------------------------
destination_rabbitmq/__init__.py          2      0   100%
destination_rabbitmq/destination.py      60      7    88%
---------------------------------------------------------
TOTAL                                    62      7    89%

Build Passed

Test summary info:

All Passed

Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can proceed with publishing and merging without airbyte review

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Sep 9, 2022

/publish connector=connectors/destination-rabbitmq

🕑 Publishing the following connectors:
connectors/destination-rabbitmq
https://github.com/airbytehq/airbyte/actions/runs/3021704279


Connector Did it publish? Were definitions generated?
connectors/destination-rabbitmq

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@yurii-bidiuk yurii-bidiuk marked this pull request as ready for review September 9, 2022 10:54
@yurii-bidiuk yurii-bidiuk merged commit 8c56eeb into master Sep 9, 2022
@yurii-bidiuk yurii-bidiuk deleted the bidiuk/16420-rabbitmq-change-spec branch September 9, 2022 10:54
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
…hq#16528)

* Destination RabbitMQ make password as airbyte_secret

* update changelog

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
…hq#16528)

* Destination RabbitMQ make password as airbyte_secret

* update changelog

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/rabbitmq
Projects
None yet
Development

Successfully merging this pull request may close these issues.

password field is not marked as secret in RabbitMQ Destination
3 participants