fix cdk bug to send legacy format if connector overrides read() #16566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
approved these changes
Sep 10, 2022
| # send state in the old format for these connectors, but once all have been upgraded, this block can be removed | ||
| # vars(self.__class__) checks if the current class directly overrides the read() function | ||
| if "read" in vars(self.__class__): | ||
| return state_obj |
There was a problem hiding this comment.
Maybe we should log something warning the connector developer to do… something soon
There was a problem hiding this comment.
agreed, i think i'll jot this down to follow up and add this to the next checkin of per-stream. not sure the best way of surfacing it, maybe a logger message, but not really something we should be surfacing to customers viewing logs
|
/publish-cdk dry-run=true
|
|
/publish-cdk dry-run=false
|
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
…ytehq#16566) * fix cdk bug to send legacy format if connector overrides read() * fix comment * update changelog and setup.py
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…ytehq#16566) * fix cdk bug to send legacy format if connector overrides read() * fix comment * update changelog and setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
For connectors like
source-fakerthat override theread()function, they might not be able to support the new list based format that state arrives in. To guard against this, we should continue to send the old format for these types of connectors.How
While reading in state from
source.pywe can determine if the connector directly overrides thereadfunction usingvars(self.__class__). In that case, we continue to send the flat state object instead of state in the new formatTested against
source-fakerwhich implements its own read() which receives the old state format