Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support for full minio endpoint names #16571

Merged
merged 1 commit into from
Sep 12, 2022
Merged

fix: Add support for full minio endpoint names #16571

merged 1 commit into from
Sep 12, 2022

Conversation

michaeljguarino
Copy link
Contributor

@michaeljguarino michaeljguarino commented Sep 10, 2022

What

The current chart can only allow minio hosts with http schemes (not https) and requires you to specify a port. It's probably more convenient to take a full string of the endpoint url, which this variable provides the ability to do.

How

just a slight modification to a helper template

Recommended reading order

the order on github is fine to use

馃毃 User Impact 馃毃

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 馃毃馃毃 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

The current chart can only allow minio hosts with http schemes (not https) and requires you to specify a port.  It's probably more convenient to take a full string of the endpoint url, which this variable provides the ability to do.
@CLAassistant
Copy link

CLAassistant commented Sep 10, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/platform issues related to the platform kubernetes labels Sep 10, 2022
@michaeljguarino michaeljguarino changed the title Add support for full minio endpiont names Add support for full minio endpoint names Sep 10, 2022
Copy link
Contributor

@xpuska513 xpuska513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for your contribution!

@xpuska513 xpuska513 changed the title Add support for full minio endpoint names fix: Add support for full minio endpoint names Sep 12, 2022
@xpuska513 xpuska513 merged commit 7d329de into airbytehq:master Sep 12, 2022
@michaeljguarino michaeljguarino deleted the minio-endpoint branch September 12, 2022 20:31
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
The current chart can only allow minio hosts with http schemes (not https) and requires you to specify a port.  It's probably more convenient to take a full string of the endpoint url, which this variable provides the ability to do.
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
The current chart can only allow minio hosts with http schemes (not https) and requires you to specify a port.  It's probably more convenient to take a full string of the endpoint url, which this variable provides the ability to do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform community kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants