Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing schedule dual write and consume the new format for tracking metadata #16590

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

mfsiega-airbyte
Copy link
Contributor

What

Fixes a null pointer exception when the old schedule format is expected.

How

This change performs the dual write (in case there are others places that still expect the old format), and also consumes the new format if it's available.

@mfsiega-airbyte mfsiega-airbyte temporarily deployed to more-secrets September 12, 2022 14:02 Inactive
@mfsiega-airbyte mfsiega-airbyte temporarily deployed to more-secrets September 12, 2022 14:43 Inactive
@mfsiega-airbyte mfsiega-airbyte temporarily deployed to more-secrets September 12, 2022 14:48 Inactive
Copy link
Contributor

@pmossman pmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding a test case to verify!

@mfsiega-airbyte mfsiega-airbyte merged commit 88a3249 into master Sep 12, 2022
@mfsiega-airbyte mfsiega-airbyte deleted the msiega/cronstrings3 branch September 12, 2022 15:32
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
…ng metadata (airbytehq#16590)

* make sure we dual write the old schedule format

* consume the new schedule format for the tracking metadata
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
…ng metadata (airbytehq#16590)

* make sure we dual write the old schedule format

* consume the new schedule format for the tracking metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants