#1571 Issue: adopt Best practice for Google Sheets Source #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevhenii-ldv
commented
Jan 15, 2021
| @@ -119,8 +123,7 @@ def read( | |||
|
|
|||
| for row in row_values: | |||
| if Helpers.is_row_empty(row): | |||
| encountered_blank_row = True | |||
There was a problem hiding this comment.
I'm not sure about the correctness of these changes, but the previous code stopped reading data after it found one empty line, for example, if after the header line there is an empty line and then data, then we do not read this data. I made it so that all data in a specific ROW_BACTH_SIZE was read, and the cycle was interrupted when there were no records in this values_range.
Let me know please, if this is not the correct logic, I will revert the code to the previous state.
sherifnada
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adopt Best practice for Google Sheets Source.
Checklist
If API connector: implements incremental sync (where possible -- not all streams will allow this)