Source File: fix schema generation for json files containing an array

[davydov-d]

What

https://github.com/airbytehq/oncall/issues/547
When a json file schema is discovered, it returns a schema of an array if it is a root element of a file.

How

Instead, return a schema of an inside dict elements

[davydov-d]

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3060038973
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3060038973
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       275     42    85%
source_file/source.py        51     27    47%
---------------------------------------------
TOTAL                       328     69    79%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/source.py        51      0   100%
source_file/__init__.py       2      0   100%
source_file/client.py       275     34    88%
---------------------------------------------
TOTAL                       328     34    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1325    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 26 passed, 1 skipped in 65.29s (0:01:05) ===================

[pedroslopez]

This looks good, but is there any thing to do / other validation if the json file is an array of anything other than object?

For example, if the json file is just ["apple", "orange", "kiwi"] this is probably invalid. (maybe a validation in check should be added here, but feel free to make a different issue for this and tackle it separately)

[davydov-d]

seems to be valid

>>> builder = genson.SchemaBuilder()
>>> builder.add_object(['a', 'b', 'c'])
>>> builder.to_schema()["items"]
{'type': 'string'}

[pedroslopez]

Yeah the schema is technically valid for this, but what I mean is this will also cause issues with normalization since we expect each stream to have an object with properties as its schema (in this case it will just be a string). We probably shouldn't accept json files that aren't objects or an array of objects. Does that make sense?

[davydov-d]

oh I see now
sure it makes sense, I will create a separate issue to work on this problem

[davydov-d]

here it is https://github.com/airbytehq/airbyte/issues/16863

[davydov-d]

/publish connector=connectors/source-file

🕑 Publishing the following connectors:
connectors/source-file
https://github.com/airbytehq/airbyte/actions/runs/3080911294

Connector	Did it publish?	Were definitions generated?
connectors/source-file	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

[davydov-d]

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/3081050614

Connector	Did it publish?	Were definitions generated?
connectors/source-file-secure	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️