Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an explicit v0 version of the protocol #16797

Merged
merged 5 commits into from
Sep 21, 2022

Conversation

gosusnp
Copy link
Contributor

@gosusnp gosusnp commented Sep 16, 2022

What

  • To prepare for a more explicit version tracking of the Airbyte Protocol, we should keep track of each major specs of the protocol.

How

Introduce folders with the major version of the protocol.
The new tree would be

airbyte-protocol/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml
airbyte-protocol/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml
airbyte-protocol/protocol-models/src/main/resources/airbyte_protocol/v1/airbyte_protocol.yaml

For the first iteration, airbyte_protocol/v0/airbyte_protocol.yaml is going to be a symlink towards, airbyte_protocol/airbyte_protocol.yaml.
When we add v1, we should modify airbyte_protocol/airbyte_protocol.yaml to be a symlink towards the most recent version (ie v1).

🚨 User Impact 🚨

There should be no impact since the current file remains the source of truth.

@gosusnp gosusnp requested a review from a team as a code owner September 16, 2022 00:53
@github-actions github-actions bot added area/platform issues related to the platform area/protocol labels Sep 16, 2022
@gosusnp gosusnp temporarily deployed to more-secrets September 16, 2022 00:55 Inactive
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Is the plan to create a ticket/issue right now to track the symlink switch to v1?

@@ -0,0 +1 @@
../airbyte_protocol.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Symlinks are rendered like this in github.

@gosusnp gosusnp temporarily deployed to more-secrets September 16, 2022 16:40 Inactive
@gosusnp
Copy link
Contributor Author

gosusnp commented Sep 16, 2022

:shipit: Is the plan to create a ticket/issue right now to track the symlink switch to v1?

@jdpgrailsdev, I created #16814 to track this.

@gosusnp gosusnp temporarily deployed to more-secrets September 21, 2022 16:27 Inactive
@gosusnp gosusnp temporarily deployed to more-secrets September 21, 2022 17:30 Inactive
@gosusnp gosusnp temporarily deployed to more-secrets September 21, 2022 20:27 Inactive
@gosusnp gosusnp merged commit bded0ac into master Sep 21, 2022
@gosusnp gosusnp deleted the gosusnp/15989-build_protocol_with_version_namespace branch September 21, 2022 23:31
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants