Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16617] Source BigQuery: added user agent header #16902

Merged
merged 8 commits into from
Sep 22, 2022

Conversation

alexandr-shegeda
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda commented Sep 19, 2022

What

To enable the reporting, partners should update Google Cloud Storage and BigQuery API calls with the User Agent string.

How

Added header user-agent with product information.

Recommended reading order

  1. BigQueryDatabase.java

🚨 User Impact 🚨

No user impact.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets September 19, 2022 19:10 Inactive
@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets September 21, 2022 11:09 Inactive
@alexandr-shegeda alexandr-shegeda marked this pull request as ready for review September 22, 2022 12:38
@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets September 22, 2022 12:40 Inactive
updated image tag, added changelog
@alexandr-shegeda alexandr-shegeda requested a review from a team as a code owner September 22, 2022 12:40
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 22, 2022
@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-bigquery

@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets September 22, 2022 12:43 Inactive
@alexandr-shegeda
Copy link
Contributor Author

alexandr-shegeda commented Sep 22, 2022

/test connector=connectors/source-bigquery

🕑 connectors/source-bigquery https://github.com/airbytehq/airbyte/actions/runs/3106001976
❌ connectors/source-bigquery https://github.com/airbytehq/airbyte/actions/runs/3106001976
🐛 https://gradle.com/s/xs6xkxpmkqrxw

Build Failed

Test summary info:

Could not find result summary

@alexandr-shegeda
Copy link
Contributor Author

alexandr-shegeda commented Sep 22, 2022

/test connector=connectors/source-bigquery

🕑 connectors/source-bigquery https://github.com/airbytehq/airbyte/actions/runs/3106301867
✅ connectors/source-bigquery https://github.com/airbytehq/airbyte/actions/runs/3106301867
No Python unittests run

Build Passed

Test summary info:

All Passed

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-bigquery

@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets September 22, 2022 14:31 Inactive
@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-bigquery

@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets September 22, 2022 14:49 Inactive
@alexandr-shegeda
Copy link
Contributor Author

alexandr-shegeda commented Sep 22, 2022

/publish connector=connectors/source-bigquery

🕑 Publishing the following connectors:
connectors/source-bigquery
https://github.com/airbytehq/airbyte/actions/runs/3106495858


Connector Did it publish? Were definitions generated?
connectors/source-bigquery

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@alexandr-shegeda alexandr-shegeda merged commit 6465aae into master Sep 22, 2022
@alexandr-shegeda alexandr-shegeda deleted the osheg/16617-source-bigquery-user-agent branch September 22, 2022 18:45
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
* [16617] Source BigQuery: added user agent header

* [16617] Source BigQuery: added user agent header

* [16617] Source BigQuery: added user agent header
updated image tag, added changelog

* [16617] Source BigQuery: added user agent header
fixed NPE

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* [16617] Source BigQuery: added user agent header

* [16617] Source BigQuery: added user agent header

* [16617] Source BigQuery: added user agent header
updated image tag, added changelog

* [16617] Source BigQuery: added user agent header
fixed NPE

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bigquery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery Source should comply with Google's partner attribution requirements
3 participants