SentryJobErrorReportingClient: set event platform from parsed stacktrace #16906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
pedroslopez
commented
Sep 19, 2022
Comment on lines
28
to
29
| public static final String ERROR_MAP_MESSAGE_KEY = "errorMessage"; | ||
| public static final String ERROR_MAP_TYPE_KEY = "errorType"; |
There was a problem hiding this comment.
Was not being used
pedroslopez
changed the title
pedroslopez
changed the title
pedroslopez
changed the title
sherifnada
approved these changes
Sep 21, 2022
| @@ -23,10 +23,9 @@ | |||
| @SuppressWarnings("PMD.AvoidLiteralsInIfCondition") | |||
| public class SentryExceptionHelper { | |||
|
|
|||
| private static final Logger LOGGER = LoggerFactory.getLogger(SentryExceptionHelper.class); | |||
| public record SentryParsedException(String platform, List<SentryException> exceptions) {} | |||
There was a problem hiding this comment.
Maybe an enum of the platforms is more appropriate here?
There was a problem hiding this comment.
👍🏻 done in 85cbf67
This was referenced Sep 27, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
…ace (airbytehq#16906) * set sentry event platform from parsed stacktrace * fix pmd * use an enum * use enum in test * fix imports * fix imports * format * fix imports
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…ace (airbytehq#16906) * set sentry event platform from parsed stacktrace * fix pmd * use an enum * use enum in test * fix imports * fix imports * format * fix imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Set sentry's
platformon events for better display and so we can use it to determine who should be paged.From the Sentry docs https://develop.sentry.dev/sdk/event-payloads/#required-attributes:
So dbt errors will still be sent as
otherclose https://github.com/airbytehq/airbyte-cloud/issues/2650
How
SentryParsedExceptionclass from the exception parser that includes the platform.SentryParsedException's platform to set it on the event and add a tag