Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email autofill from search params #16936

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Conversation

letiescanciano
Copy link
Contributor

@letiescanciano letiescanciano commented Sep 20, 2022

What

We are implementing a new form in airbyte.com homepage, to allow users enter their email directly in the homepage.
Then, when they submit that form they will be redirected to cloud.airbyte.io/signup?email=xxx&firstname=xxx.....
Screen Shot 2022-09-20 at 6 28 59 PM

This change allow us to read searchParams and pre-fill the form with known values preventing the user to have to enter those details again.
Screen Shot 2022-09-20 at 7 18 31 PM

Also, by interacting with a Hubspot form in airbyte.com we will be able to track that user properly in Hubspot.

How

  • read searchParams
  • build initialValues with values coming from searchParams if those exist

馃毃 User Impact 馃毃

Users will see the pre-fill values if coming from entering their email in the homepage.

@letiescanciano letiescanciano requested a review from a team as a code owner September 20, 2022 17:18
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Sep 20, 2022
Copy link
Contributor

@dizel852 dizel852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM
Also tested locally - no issues.

@letiescanciano letiescanciano merged commit 7f2c8be into master Sep 22, 2022
@letiescanciano letiescanciano deleted the leti/add-fill-email-signup branch September 22, 2022 06:22
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
* Add email autofill from search params
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* Add email autofill from search params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants