Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Salesforce: perform call to objects list in connection check #17094

Merged
merged 3 commits into from Sep 23, 2022

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/oncall/issues/629

How

Perform the call to objects list which causes 403 error in a check stage

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 23, 2022
@davydov-d
Copy link
Collaborator Author

davydov-d commented Sep 23, 2022

/test connection=connectors/source-salesforce

Error: Unexpected inputs provided: ["connection"]

@davydov-d
Copy link
Collaborator Author

davydov-d commented Sep 23, 2022

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3113334484
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3113334484
Python tests coverage:

Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/__init__.py            2      0   100%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/api.py               151     19    87%
source_salesforce/streams.py           307     71    77%
source_salesforce/rate_limiting.py      22      6    73%
source_salesforce/source.py             95     40    58%
source_salesforce/utils.py               8      7    12%
--------------------------------------------------------
TOTAL                                  593    144    76%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/utils.py               8      0   100%
source_salesforce/__init__.py            2      0   100%
source_salesforce/api.py               151     14    91%
source_salesforce/source.py             95      9    91%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/streams.py           307     41    87%
source_salesforce/rate_limiting.py      22      3    86%
--------------------------------------------------------
TOTAL                                  593     68    89%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one concern here about the check time, how that changed with this change?

@davydov-d
Copy link
Collaborator Author

Only one concern here about the check time, how that changed with this change?

@bazarnov in average 0.5 sec vs 1.5 sec on my local machine using integration test creds

@davydov-d
Copy link
Collaborator Author

davydov-d commented Sep 23, 2022

/publish connector=connectors/source-salesforce

🕑 Publishing the following connectors:
connectors/source-salesforce
https://github.com/airbytehq/airbyte/actions/runs/3114784731


Connector Did it publish? Were definitions generated?
connectors/source-salesforce

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit d62f881 into master Sep 23, 2022
@davydov-d davydov-d deleted the ddavydov/#629-source-salesforce-tune-check branch September 23, 2022 18:57
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
…irbytehq#17094)

* airbytehq#629 oncall - source salesforce: perform call to objects list in connection check

* source salesforce: upd changelog

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
…irbytehq#17094)

* airbytehq#629 oncall - source salesforce: perform call to objects list in connection check

* source salesforce: upd changelog

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesforce
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants