🪟 🔧 Prevent rerendering on stale queries #17106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
krishnaglick
approved these changes
Sep 23, 2022
This was referenced Sep 27, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This prevents react-query from rerendering a component that uses a react-query hook in case the query turns stale. Since there is no new data we're not needing to rerender components in this case, especially since we have nowhere any specific logic that would require to detect whether a query is stale.
This will prevent some nasty rerenders e.g. of the connection listing page, that will always rerender twice (once for new data and then once for the stale query), which causing some hickups with the switch loading animation if you toggle connections to quickly.
How to test?
You can check that e.g. the connection list page (or any other page that has queries that turn stale) is not rerendering twice via the React dev tools. There should be no other affect than that.