Data plane needs gcp secret hydrator and persistence for replication activity #17149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
pmossman
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
@xiaohansong this looks good from a code perspective! Did this only come up now because our test syncs that we ran in AWS Dev didn't require secrets?
|
@pmossman that's right - especially for destination because I always used e2e testing one |
This was referenced Sep 27, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
…activity (airbytehq#17149) * use prototype for jwt signature because we need a new one * add comments on why using provider and prototype: * secret hydrator fix for data plane * style fix
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…activity (airbytehq#17149) * use prototype for jwt signature because we need a new one * add comments on why using provider and prototype: * secret hydrator fix for data plane * style fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Give GCP Secret hydrator and persistence for data plane workers.