Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Modal component to components/ui and fix imports #17165

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

edmundito
Copy link
Contributor

What

Related to #17101

Moves the Modal component to components/ui and gets rid of the import ambiguity.

@edmundito edmundito requested a review from a team as a code owner September 26, 2022 19:48
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Sep 26, 2022
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

As a future todo, it looks like in Storybook this modal renders generic buttons rather than our styled buttons -- is that what we want?

@edmundito
Copy link
Contributor Author

@tealjulia I liked the idea so I updated the modal storybook.

@edmundito edmundito merged commit 7c4980b into master Sep 27, 2022
@edmundito edmundito deleted the edmundito/move-modal-component branch September 27, 2022 18:24
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
)

* Move Modal component to components/ui and fix imports

* Update Modal storybook with more content, use UI component Buttons
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
)

* Move Modal component to components/ui and fix imports

* Update Modal storybook with more content, use UI component Buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants