Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bmoric/restore temporal cleaning cron #17258

Merged
merged 4 commits into from
Sep 27, 2022
Merged

Bmoric/restore temporal cleaning cron #17258

merged 4 commits into from
Sep 27, 2022

Conversation

benmoriceau
Copy link
Contributor

@benmoriceau benmoriceau commented Sep 27, 2022 •
edited

What

This is restoring the move of the temporal client to its own module and the update of airbyte cron.

THe main change since the revert are:

  • Add a publish task in the build.gradle of airbyte-commons-temporal module
  • Change the injection related annotations from javax.inject to jakarta.inject
  • Change the temporalRetentionInDays in TemporalUtils from a @Value to a @Property injection type.

@github-actions github-actions bot added area/platform issues related to the platform area/server area/worker Related to worker labels Sep 27, 2022
jdpgrailsdev
jdpgrailsdev approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@benmoriceau benmoriceau merged commit 3c457e0 into master Sep 27, 2022
@benmoriceau benmoriceau deleted the bmoric/restore-temporal-cleaning-cron branch September 27, 2022 17:59
This was referenced Sep 27, 2022
Closed
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@benmoriceau @robbinhan
Bmoric/restore temporal cleaning cron (airbytehq#17258)
18bb7e0 
* Revert "Revert "Bmoric/temporal cleaning cron (airbytehq#16414)" (airbytehq#17192)"

This reverts commit 7516679.

* Generate an artifact

* Change missing property from value to property
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@benmoriceau @jhammarstedt
Bmoric/restore temporal cleaning cron (airbytehq#17258)
eacd834 
* Revert "Revert "Bmoric/temporal cleaning cron (airbytehq#16414)" (airbytehq#17192)"

This reverts commit 7516679.

* Generate an artifact

* Change missing property from value to property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

@gosusnp gosusnp Awaiting requested review from gosusnp

Assignees
No one assigned
Labels
area/platform issues related to the platform area/server area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benmoriceau @jdpgrailsdev