Toph increases rate limit for shared issues #17265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also renames the file to be more clear to outsiders
took me some time to find, saving others
supertopher
force-pushed
the
toph_increases_rate_limit_for_shared_issues
branch
from
c555de0
to
25dbefb
Compare
supertopher
commented
Sep 27, 2022
| run: | | ||
| ./tools/bin/find_non_rate_limited_PAT \ | ||
| ${{ secrets.OCTAVIA_PAT }} \ | ||
| ${{ secrets.OCTAVIA_4_ROOT_ACCESS }} |
There was a problem hiding this comment.
this is a new Octavia user with new PAT limits
lmossman
reviewed
Sep 27, 2022
git-phu
approved these changes
Sep 27, 2022
| steps: | ||
| - uses: nick-fields/private-action-loader@v3 | ||
| with: | ||
| pal-repo-token: "${{ secrets.OCTAVIA_PAT }}" |
There was a problem hiding this comment.
Can we use the find_valid_pat output token for this as well?
There was a problem hiding this comment.
ty pete. missed it
|
Looks like this is failing. https://github.com/airbytehq/airbyte/actions/runs/3139838149/jobs/5100623564
|
|
I'm pretty sure I checked the wrong pipeline to verify this worked 🤦 working on a fix now |
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Adds second PAT for issue labeller also renames the file to be more clear to outsiders * Adds reference to code that runs took me some time to find, saving others * comment cleanup * use find_valid_pat output for both actions
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Adds second PAT for issue labeller also renames the file to be more clear to outsiders * Adds reference to code that runs took me some time to find, saving others * comment cleanup * use find_valid_pat output for both actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sooo many sad people have hit this rate limit. there is actually alot of underlying issues.
this PR is a bandaid for rate limits AND a clarification on what is running