🪟 🎨 Do not render InfoToolTip if there is not content to render #17276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
timroes
approved these changes
Sep 27, 2022
lmossman
deleted the
lmossman/dont-render-info-tooltip-if-no-description
branch
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
…ytehq#17276) * do not render InfoToolTip if there is not content to render * remove px
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…ytehq#17276) * do not render InfoToolTip if there is not content to render * remove px
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As evidenced by this slack thread, it is confusing for users if we render an ⓘ InfoToolTip for a field, and that tooltip doesn't actually have any content to display.
How
This PR makes the UX slightly less confusing by just not rendering the info tooltip if there is no content to render. Example screenshot of the same connector with these changes, showing that the info tooltip is no longer rendered:
This PR also slightly refactors the LabelInfo component so that the styling is better in cases where there are examples but no descriptions to display, e.g.
