Remove validation #17280
Merged
Remove validation #17280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
This reverts commit 156a227.
alovew
approved these changes
Sep 27, 2022
benmoriceau
added a commit
that referenced
this pull request
Sep 27, 2022
This reverts commit 0404203.
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Remove validation * Revert "Remove validation" This reverts commit 156a227. * Put the validation behind a feature flag * Fix typo * format
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Remove validation * Revert "Remove validation" This reverts commit 156a227. * Put the validation behind a feature flag * Fix typo * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the stream migration validation
This is related to https://github.com/airbytehq/oncall/issues/698
Some connector don't emit all the state that should be emitted, resulting in a validation error.
This validation is deprecated for the cloud project because platform has been migrated a while ago and can aggregate state properly. Another review will be done in the cloud in order to properly set this feature flag.