🐛 Source Salesforce: fix response encoding - #17314

Merged

Artem Inzhyyants (artem1205) merged 6 commits into

15950-source-salesforce-decoding

Sep 29, 2022

Artem Inzhyyants (artem1205) commented Sep 28, 2022

Contributor

What

Resolving: #15950

How

Use the encoding information from the response headers

Recommended reading order

x.java
y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.


          🐛 Source Salesforce: fix response encoding

a770d9d

Artem Inzhyyants (artem1205) added area/connectors connectors/source/salesforce labels

Artem Inzhyyants (artem1205) requested review from Arsen Losenko (arsenlosenko) and Serhii Chvaliuk (grubberr)

September 28, 2022 10:37

Artem Inzhyyants (artem1205) commented Sep 28, 2022 •

edited by github-actions Bot

Loading

Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3142836304
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3142836304
🐛 https://gradle.com/s/ciwlbfycepbtu

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED integration_tests/bulk_error_test.py::test_not_queryable_stream - requ...
	 �[31m================== �[31m�[1m1 failed�[0m, �[32m5 passed�[0m, �[33m78 warnings�[0m�[31m in 37.04s�[0m�[31m ===================�[0m

Arsen Losenko (arsenlosenko) approved these changes

View reviewed changes

Artem Inzhyyants (artem1205) commented Sep 28, 2022 •

edited by github-actions Bot

Loading

Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3144168865
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3144168865
🐛 https://gradle.com/s/n2ccvm4dv7aam

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_memory.py::test_memory_download_data[100k records] - a...
	 FAILED unit_tests/test_memory.py::test_memory_download_data[200k records] - a...
	 �[31m============ �[31m�[1m2 failed�[0m, �[32m68 passed�[0m, �[33m224 warnings�[0m�[31m in 93.14s (0:01:33)�[0m�[31m =============�[0m


          🐛 Source Salesforce: fix REQUEST_LIMIT_EXCEEDED error handling

ae91874

Artem Inzhyyants (artem1205) commented Sep 28, 2022 •

edited by github-actions Bot

Loading

Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3144389135
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3144389135
🐛 https://gradle.com/s/xh736mtkdhc2o

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_memory.py::test_memory_download_data[100k records] - a...
	 FAILED unit_tests/test_memory.py::test_memory_download_data[200k records] - a...
	 �[31m============ �[31m�[1m2 failed�[0m, �[32m68 passed�[0m, �[33m224 warnings�[0m�[31m in 95.44s (0:01:35)�[0m�[31m =============�[0m


          🐛 Source Salesforce: fix test memory

32e375b

Artem Inzhyyants (artem1205) commented Sep 28, 2022 •

edited by github-actions Bot

Loading

Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3144672792
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3144672792
🐛

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
================== 1 failed, 29 passed in 1992.86s (0:33:12) ===================

Artem Inzhyyants (artem1205) commented Sep 29, 2022 •

edited by github-actions Bot

Loading

Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3152605765
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3152605765
Python tests coverage:

Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/__init__.py            2      0   100%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/api.py               151     19    87%
source_salesforce/streams.py           299     63    79%
source_salesforce/rate_limiting.py      22      6    73%
source_salesforce/source.py             95     40    58%
source_salesforce/utils.py               8      7    12%
--------------------------------------------------------
TOTAL                                  585    136    77%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/utils.py               8      0   100%
source_salesforce/__init__.py            2      0   100%
source_salesforce/api.py               151     14    91%
source_salesforce/source.py             95      9    91%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/rate_limiting.py      22      3    86%
source_salesforce/streams.py           299     42    86%
--------------------------------------------------------
TOTAL                                  585     69    88%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

Artem Inzhyyants (artem1205) commented Sep 29, 2022 •

edited by github-actions Bot

Loading

Contributor Author

/publish connector=connectors/source-salesforce

🕑 Publishing the following connectors:
connectors/source-salesforce
https://github.com/airbytehq/airbyte/actions/runs/3153101726

Connector	Did it publish?	Were definitions generated?
connectors/source-salesforce	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Artem Inzhyyants (artem1205) and others added 2 commits

September 29, 2022 19:17


          🐛 Source Salesforce: Bump version to 1.0.19

48dda2e


          Merge branch 'master' into 15950-source-salesforce-decoding

895f177

Artem Inzhyyants (artem1205) commented Sep 29, 2022 •

edited by github-actions Bot

Loading

Contributor Author

/publish connector=connectors/source-salesforce

🕑 Publishing the following connectors:
connectors/source-salesforce
https://github.com/airbytehq/airbyte/actions/runs/3153295168

Connector	Did it publish?	Were definitions generated?
connectors/source-salesforce	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️


          auto-bump connector version [ci skip]

1835aba

Artem Inzhyyants (artem1205) merged commit f9f9fab into master

Artem Inzhyyants (artem1205) deleted the 15950-source-salesforce-decoding branch

September 29, 2022 18:13

Octavia Squidington III (octavia-squidington-iii) mentioned this pull request

Bump Airbyte version from 0.40.10 to 0.40.11 #17610

Merged

Johan Hammarstedt (jhammarstedt) pushed a commit to jhammarstedt/airbyte that referenced this pull request


          🐛 Source Salesforce: fix response encoding (airbytehq#17314)

0c5c669

* 🐛 Source Salesforce: fix response encoding

* 🐛 Source Salesforce: fix REQUEST_LIMIT_EXCEEDED error handling

* 🐛 Source Salesforce: fix test memory

* 🐛 Source Salesforce: Bump version to 1.0.19

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors connectors/source/salesforce