馃獰 馃敡 Move UI components from base to ui
#17323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
edmundito
commented
Sep 28, 2022
| @@ -1,4 +1,4 @@ | |||
| export * from "./base"; | |||
| export * from "./ui"; | |||
There was a problem hiding this comment.
This will be removed separately.
krishnaglick
approved these changes
Sep 28, 2022
* Update imports to leave Titles in base folder
edmundito
force-pushed
the
edmundito/move-base-components
branch
from
b752a96
to
9a0b964
Compare
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Move AlertBanner from base to ui * Move components from base to ui * Update imports to leave Titles in base folder
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Move AlertBanner from base to ui * Move components from base to ui * Update imports to leave Titles in base folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Related to #17101
This change moves all the UI library components in
components/basetocomponents/ui.The
Titlescomponents remain inbasebecause they are deprecated and should be removed.How
Move components, cleanup imports, and update imports