Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Upgrade Rest Hooks to v5 #1736

Merged
merged 2 commits into from Jan 21, 2021
Merged

Conversation

ntucker
Copy link
Contributor

@ntucker ntucker commented Jan 20, 2021

What

Rest Hooks handles networking data for front end. 5 was just released with many improvements. Full release notes and migration guide to come.

How

Describe the solution

  • Some types are more strictly recognized, so fixed those errors
  • Updated typescript to v4 to support named tuples
  • Fixed super.call generics breaking with some explicit type additions
  • Import from /lib/ path is not recommended - moved to top-level import
  • Added missing message member to one resource.
  • We use SchemaDetail and SchemaList in the BaseResource so they can be overridden children classes.
    • Use the Resource itself in children (T or T[])

Given lack of use of useInvalidator() as well as custom managers, this should be the extent of changes needed.

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

@ntucker ntucker marked this pull request as ready for review January 20, 2021 18:57
@ntucker
Copy link
Contributor Author

ntucker commented Jan 20, 2021

@jamakase Thought I'd take a crack at some real world migrations.

@cgardens
Copy link
Contributor

@ntucker thanks for doing this! we certainly appreciate a lot. @jamakase will review it since he's our Rest Hooks expert, but i just wanted to say thanks!

Copy link
Contributor

@jamakase jamakase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @ntucker and thank you a lot for your help with rest-hooks in this project. We highly appreciate it.

@jamakase jamakase self-assigned this Jan 21, 2021
@jamakase jamakase merged commit 6ca0286 into airbytehq:master Jan 21, 2021
jamakase added a commit that referenced this pull request Jan 21, 2021
jamakase added a commit that referenced this pull request Jan 21, 2021
@michel-tricot
Copy link
Contributor

Thank you @ntucker for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants