New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: Upgrade Rest Hooks to v5 #1736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jamakase Thought I'd take a crack at some real world migrations. |
jamakase
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @ntucker and thank you a lot for your help with rest-hooks
in this project. We highly appreciate it.
airbyte-webapp/src/pages/ConnectionPage/pages/CreationFormPage/CreationFormPage.tsx
Show resolved
Hide resolved
jamakase
added a commit
that referenced
this pull request
Jan 21, 2021
Thank you @ntucker for your PR! |
jamakase
added a commit
that referenced
this pull request
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rest Hooks handles networking data for front end. 5 was just released with many improvements. Full release notes and migration guide to come.
How
Describe the solution
message
member to one resource.SchemaDetail
andSchemaList
in the BaseResource so they can be overridden children classes.T
orT[]
)Given lack of use of
useInvalidator()
as well as custom managers, this should be the extent of changes needed.Pre-merge Checklist