Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add distribution gradle plugin #17409

Merged
merged 2 commits into from
Sep 29, 2022
Merged

add distribution gradle plugin #17409

merged 2 commits into from
Sep 29, 2022

Conversation

colesnodgrass
Copy link
Member

What

  • fix gradle failing due to not being able to find distTar

    Could not create task ':airbyte-cli:copyGeneratedTar'.

    Could not get unknown property 'distTar' for task ':airbyte-cli:copyGeneratedTar' of type org.gradle.api.tasks.Copy.

How

  • add the distribution plugin to the main build.gradle file

@colesnodgrass colesnodgrass temporarily deployed to more-secrets September 29, 2022 18:06 Inactive
jdpgrailsdev
jdpgrailsdev approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@colesnodgrass
Copy link
Member Author

@davinchia comment has been added

@colesnodgrass colesnodgrass temporarily deployed to more-secrets September 29, 2022 18:18 Inactive
@davinchia
Copy link
Contributor

LGTM 🎸

@colesnodgrass colesnodgrass temporarily deployed to more-secrets September 29, 2022 19:07 Inactive
@colesnodgrass colesnodgrass merged commit 48340ca into master Sep 29, 2022
@colesnodgrass colesnodgrass deleted the cole/add-distribution-plugin branch September 29, 2022 19:26
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Oct 5, 2022
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@colesnodgrass @jhammarstedt
add distribution gradle plugin (airbytehq#17409)
91a4fcb 
* add distribution gradle plugin

* add comment explaining new plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

@davinchia davinchia davinchia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@colesnodgrass @davinchia @jdpgrailsdev