Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Removes $ from terminal commands to allow direct copying. #17467

Merged
merged 2 commits into from Sep 30, 2022
Merged

📖 Removes $ from terminal commands to allow direct copying. #17467

merged 2 commits into from Sep 30, 2022

Conversation

natalyjazzviolin
Copy link
Contributor

@natalyjazzviolin natalyjazzviolin commented Sep 30, 2022 •
edited

What

  • Fixes local build by adding missing link to DV360 connector changelog.
  • Removes $ at the beginning of each terminal command, as this makes the copy button in the corner of code blocks obsolete and can confuse beginner coders.

Original:
Screen Shot 2022-09-30 at 11 30 39 AM

Modified:
Screen Shot 2022-09-30 at 11 30 54 AM

Recommended reading order

  1. docs/integrations/sources/dv360.md
  2. Other files in order.

🚨 User Impact 🚨

No breaking changes.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 30, 2022
@natalyjazzviolin natalyjazzviolin merged commit 7bc911e into master Sep 30, 2022
@natalyjazzviolin natalyjazzviolin deleted the nataly-update-lowcode-docs branch September 30, 2022 15:54
artem1205 pushed a commit that referenced this pull request Sep 30, 2022
@natalyjazzviolin @artem1205
📖 Removes $ from terminal commands to allow direct copying. (#17467)
6c730d5 
* Removes $ from terminal commands to allow direct copying.

* Fixes build by adding missing link.
letiescanciano added a commit that referenced this pull request Oct 3, 2022
@letiescanciano
Merge branch 'master' into leti/add-segment-track-to-suggested-destin…
e6264e6 
…ations

* master: (75 commits)
  source-sentry: migrate to per-stream states (#17466)
  Greg/clickhouse polishing (#17483)
  upgrade debezium version to 1.9.6 (#17459)
  🐛 Source Twilio: Lookback_window config (#17478)
  hide S3 source connector from catalog (#17472)
  🪟 Migrate styles for Connection-related Components (#17339)
  Added new title (#17480)
  Refactor & convert `PageTitle` to SCSS (#17139)
  updated releaseStage for zendesk-talk (#17477)
  [low-code] Apply log level to stream loggers (#17284)
  🐛 Source Salesforce: filter out objects not supported by the Bulk API (#17453)
  Source Marketo: certify GA (#17445)
  Update greenhouse paginator (#17429)
  Add some services start validation to acceptance_tests.sh (#17425)
  📖 Removes $ from terminal commands to allow direct copying. (#17467)
  migrate source GA connectors to per-stream states (2) (#17410)
  Source Klaviyo: bump CDK dependency (#17422)
  Source Pinterest: change releaseStage to GA (#17045)
  Source Pinterest: Set start_date dynamically based on API restrictions for lookup (#17387)
  updated releaseStage to generally_available (#17374)
  ...
letiescanciano added a commit that referenced this pull request Oct 3, 2022
@letiescanciano
Merge branch 'master' into leti/tools-add-posthog
4a6d5f3 
* master:
  source-sentry: migrate to per-stream states (#17466)
  Greg/clickhouse polishing (#17483)
  upgrade debezium version to 1.9.6 (#17459)
  🐛 Source Twilio: Lookback_window config (#17478)
  hide S3 source connector from catalog (#17472)
  🪟 Migrate styles for Connection-related Components (#17339)
  Added new title (#17480)
  Refactor & convert `PageTitle` to SCSS (#17139)
  updated releaseStage for zendesk-talk (#17477)
  [low-code] Apply log level to stream loggers (#17284)
  🐛 Source Salesforce: filter out objects not supported by the Bulk API (#17453)
  Source Marketo: certify GA (#17445)
  Update greenhouse paginator (#17429)
  Add some services start validation to acceptance_tests.sh (#17425)
  📖 Removes $ from terminal commands to allow direct copying. (#17467)
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Oct 5, 2022
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@natalyjazzviolin @jhammarstedt
📖 Removes $ from terminal commands to allow direct copying. (airbyteh…
1ad4de2 
…q#17467)

* Removes $ from terminal commands to allow direct copying.

* Fixes build by adding missing link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

@sophia-wiley sophia-wiley Awaiting requested review from sophia-wiley

@Amruta-Ranade Amruta-Ranade Awaiting requested review from Amruta-Ranade

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation team/documentation type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@natalyjazzviolin @marcosmarxm