Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back GCS destination to Cloud #17474

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Bring back GCS destination to Cloud #17474

merged 1 commit into from
Oct 3, 2022

Conversation

grishick
Copy link
Contributor

@grishick grishick commented Sep 30, 2022 •
edited by ryankfu

What

Remove GCS destination from the list of connectors to hide in the cloud

Closes #16289 & #16288 after determination that GCS is already secured

@grishick grishick requested a review from a team as a code owner September 30, 2022 19:20
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Sep 30, 2022
ryankfu
ryankfu approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@ryankfu ryankfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

timroes
timroes approved these changes Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@grishick grishick merged commit d3fcbb3 into master Oct 3, 2022
@grishick grishick deleted the greg/unhide-gcs branch October 3, 2022 20:07
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Oct 5, 2022
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@grishick @jhammarstedt
Bring back GCS destination to Cloud (airbytehq#17474)
0f69f2a
@grishick grishick added the team/destinations Destinations team's backlog label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@edgao edgao edgao approved these changes

@ryankfu ryankfu ryankfu approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform team/destinations Destinations team's backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SSH tunneling ability to GCS Destination connector
4 participants
@grishick @timroes @edgao @ryankfu