Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constant for keystore prefix in test #17571

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Use constant for keystore prefix in test #17571

merged 1 commit into from
Oct 4, 2022

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Fix failing tests

How

  • Use constant for SSL keystore entries in test

Recommended reading order

  1. SSLCertificateUtilsTest.java

@jdpgrailsdev jdpgrailsdev merged commit 4ccbc67 into master Oct 4, 2022
@jdpgrailsdev jdpgrailsdev deleted the jdpgrailsdev-patch-1 branch October 4, 2022 17:22
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets October 4, 2022 17:23 Inactive
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Oct 5, 2022
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@jdpgrailsdev @jhammarstedt
Use constant for keystore prefix in test (airbytehq#17571)
db84e33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmoriceau benmoriceau benmoriceau approved these changes

@rodireich rodireich Awaiting requested review from rodireich

@gosusnp gosusnp Awaiting requested review from gosusnp

@alafanechere alafanechere Awaiting requested review from alafanechere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdpgrailsdev @benmoriceau