🪟 🎨 New design and cleanup for CircleLoader #17582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
timroes
added
ui/components
and removed
area/platform
timroes
commented
Oct 4, 2022
|
|
||
| :export { | ||
| // Export colors to be used in SVG gradients | ||
| gradientStart: colors.$blue; |
There was a problem hiding this comment.
ℹ️ linear-gradient doesn't work for fill on SVG elements, thus the gradient still need to be defined in SVG. To get access to the colors in JS, I exported them from here explicitally. They are already exported from the theme.ts file, but I consider this still to be going away once we're removing styled components, so in this case where we'll need to have this export even with SASS, I wanted to make it more explicit.
timroes
added
area/frontend
team/platform-move
area/frontend
josephkmh
approved these changes
Oct 5, 2022
edmundito
approved these changes
Oct 5, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* New design and cleanup for CircleLoader * Adjust snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improve the design of the StatusIcon circular loader:
Peek.2022-10-04.23-00.mp4
Peek.2022-10-04.23-20.mp4
This also cleans up the CircleLoader component and move it from styled-component to SCSS.
Note: The CSS classes in the snapshots seemed to change just as part of compiling new SCSS. We should exclude them from being matched, but I think that should be separate from this PR.