Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Google Search Console: improve config validation - site_urls #17751

Merged
merged 18 commits into from Oct 11, 2022
Merged

Source Google Search Console: improve config validation - site_urls #17751

merged 18 commits into from Oct 11, 2022

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Oct 7, 2022 •
edited

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Try to fix https://github.com/airbytehq/oncall/issues/716

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@grubberr
extract get_authenticator
7183652 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added the area/connectors Connector related issues label Oct 7, 2022
@grubberr
_validate_and_transform added
a79dc93 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
validate custom_reports
308e322 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
start_date, end_date
5d2d127 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
normalize_url added
fbcf0bf 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Merge branch 'master' into grubberr/oncall-716-source-google-search-c…
a43228d 
…onsole
@grubberr
move validate_site_urls inside _validate_and_tranform
75f4c1b 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
improve test_check_connection
3ffcee9 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
google-search-console.md updated
6a9c2d8 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr self-assigned this Oct 8, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 8, 2022
@grubberr
custom_reports added for testing
727a23e 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Oct 8, 2022 •
edited by github-actions bot

/test connector=connectors/source-google-search-console

🕑 connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/3210230006
✅ connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/3210230006
Python tests coverage:

Name                                                            Stmts   Miss  Cover
-----------------------------------------------------------------------------------
source_google_search_console/exceptions.py                          2      0   100%
source_google_search_console/__init__.py                            2      0   100%
source_google_search_console/streams.py                           138      8    94%
source_google_search_console/source.py                             86      9    90%
source_google_search_console/service_account_authenticator.py      14      6    57%
-----------------------------------------------------------------------------------
TOTAL                                                             242     23    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

@grubberr
update examples of site_urls
0b85604 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Oct 8, 2022 •
edited by github-actions bot

/test connector=source-google-search-console

🕑 source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/3210296303
✅ source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/3210296303
Python tests coverage:

Name                                                            Stmts   Miss  Cover
-----------------------------------------------------------------------------------
source_google_search_console/exceptions.py                          2      0   100%
source_google_search_console/__init__.py                            2      0   100%
source_google_search_console/streams.py                           138      8    94%
source_google_search_console/source.py                             86      9    90%
source_google_search_console/service_account_authenticator.py      14      6    57%
-----------------------------------------------------------------------------------
TOTAL                                                             242     23    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

@grubberr
Copy link
Contributor Author

grubberr commented Oct 10, 2022 •
edited by github-actions bot

/publish connector=source-google-search-console

🕑 Publishing the following connectors:
source-google-search-console
https://github.com/airbytehq/airbyte/actions/runs/3220036358


Connector Did it publish? Were definitions generated?
source-google-search-console ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr
Copy link
Contributor Author

grubberr commented Oct 10, 2022 •
edited by github-actions bot

/publish connector=connectors/source-google-search-console

🕑 Publishing the following connectors:
connectors/source-google-search-console
https://github.com/airbytehq/airbyte/actions/runs/3220435389


Connector Did it publish? Were definitions generated?
connectors/source-google-search-console ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr
Copy link
Contributor Author

grubberr commented Oct 10, 2022 •
edited by github-actions bot

/publish connector=connectors/source-google-search-console

🕑 Publishing the following connectors:
connectors/source-google-search-console
https://github.com/airbytehq/airbyte/actions/runs/3221465135


Connector Did it publish? Were definitions generated?
connectors/source-google-search-console ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr
Copy link
Contributor Author

grubberr commented Oct 10, 2022 •
edited by github-actions bot

/publish connector=connectors/source-google-search-console

🕑 Publishing the following connectors:
connectors/source-google-search-console
https://github.com/airbytehq/airbyte/actions/runs/3221588054


Connector Did it publish? Were definitions generated?
connectors/source-google-search-console ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr
Copy link
Contributor Author

grubberr commented Oct 11, 2022 •
edited by github-actions bot

/publish connector=connectors/source-google-search-console

🕑 Publishing the following connectors:
connectors/source-google-search-console
https://github.com/airbytehq/airbyte/actions/runs/3224576688


Connector Did it publish? Were definitions generated?
connectors/source-google-search-console ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr
Copy link
Contributor Author

grubberr commented Oct 11, 2022 •
edited by github-actions bot

/publish connector=connectors/source-google-search-console

🕑 Publishing the following connectors:
connectors/source-google-search-console
https://github.com/airbytehq/airbyte/actions/runs/3225569879


Connector Did it publish? Were definitions generated?
connectors/source-google-search-console ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr
Copy link
Contributor Author

grubberr commented Oct 11, 2022 •
edited by github-actions bot

/publish connector=connectors/source-google-search-console

🕑 Publishing the following connectors:
connectors/source-google-search-console
https://github.com/airbytehq/airbyte/actions/runs/3225745475


Connector Did it publish? Were definitions generated?
connectors/source-google-search-console ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr
revert-me
60dba77 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Oct 11, 2022 •
edited by github-actions bot

/publish connector=connectors/source-google-search-console

🕑 Publishing the following connectors:
connectors/source-google-search-console
https://github.com/airbytehq/airbyte/actions/runs/3226220701


Connector Did it publish? Were definitions generated?
connectors/source-google-search-console ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr grubberr temporarily deployed to more-secrets October 11, 2022 10:54 Inactive
@grubberr grubberr merged commit 0da8d7b into master Oct 11, 2022
@grubberr grubberr deleted the grubberr/oncall-716-source-google-search-console branch October 11, 2022 11:20
@grubberr grubberr temporarily deployed to more-secrets October 11, 2022 11:21 Inactive
This was referenced Oct 13, 2022
Closed
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@grubberr @jhammarstedt
Source Google Search Console: improve config validation - site_urls (a…
567fcb0 
…irbytehq#17751)

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsenlosenko arsenlosenko arsenlosenko approved these changes

@lazebnyi lazebnyi lazebnyi approved these changes

@davydov-d davydov-d Awaiting requested review from davydov-d

Assignees

@grubberr grubberr

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-search-console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@grubberr @arsenlosenko @lazebnyi @octavia-squidington-iv @octavia-squidington-iii