🐞 Source google sheets: fix nonetype exception when no spreadsheet id is found

[tuliren]

What

• Resolve https://github.com/airbytehq/oncall/issues/771.

[alafanechere]

Thanks for the fix! Do not forget to bump the connection version in the Dockerfile + Changelog before publishing.

[alafanechere]

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/3217941896
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/3217941896
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
google_sheets_source/models/spreadsheet_values.py      12      0   100%
google_sheets_source/models/spreadsheet.py             34      0   100%
google_sheets_source/models/__init__.py                 2      0   100%
google_sheets_source/__init__.py                        2      0   100%
google_sheets_source/helpers.py                       139     26    81%
google_sheets_source/client.py                         23      6    74%
google_sheets_source/google_sheets_source.py          107     85    21%
-----------------------------------------------------------------------
TOTAL                                                 319    117    63%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 28 passed, 1 skipped in 162.68s (0:02:42) ===================

[tuliren]

/publish connector=connectors/source-google-sheets

🕑 Publishing the following connectors:
connectors/source-google-sheets
https://github.com/airbytehq/airbyte/actions/runs/3224116116

Connector	Did it publish?	Were definitions generated?
connectors/source-google-sheets	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

[tuliren]

The publication failed:

 > [builder 2/4] RUN apk --no-cache upgrade     && pip install --upgrade pip     && apk --no-cache add tzdata build-base:
#7 0.269 qemu: qemu_thread_create: Operation not permitted
------
error: failed to solve: executor failed running [/bin/sh -c apk --no-cache upgrade     && pip install --upgrade pip     && apk --no-cache add tzdata build-base]: exit code: 139

The error looks transient though.

[alafanechere]

@tuliren the publish command is broken at the moment. This discussion here

[tuliren]

/publish connector=connectors/source-google-sheets

🕑 Publishing the following connectors:
connectors/source-google-sheets
https://github.com/airbytehq/airbyte/actions/runs/3229168024

Connector	Did it publish?	Were definitions generated?
connectors/source-google-sheets	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️