Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-salesforce: add EventWhoRelation to UNSUPPORTED_BULK_API_SALESFORCE_OBJECTS #17778

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Oct 10, 2022

What

#17453 removed EventWhoRelation from the list of UNSUPPORTED_BULK_API_SALESFORCE_OBJECTS but https://github.com/airbytehq/oncall/issues/776 showed that this salesforce object is not supported by bulk api.

How

Re-add EventWhoRelation to UNSUPPORTED_BULK_API_SALESFORCE_OBJECTS

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 10, 2022
@alafanechere alafanechere marked this pull request as ready for review October 10, 2022 10:42
@alafanechere
Copy link
Contributor Author

alafanechere commented Oct 10, 2022

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3218690406
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3218690406
Python tests coverage:

Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/__init__.py            2      0   100%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/api.py               151     19    87%
source_salesforce/streams.py           299     63    79%
source_salesforce/rate_limiting.py      22      6    73%
source_salesforce/source.py             95     40    58%
source_salesforce/utils.py               8      7    12%
--------------------------------------------------------
TOTAL                                  585    136    77%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/utils.py               8      0   100%
source_salesforce/__init__.py            2      0   100%
source_salesforce/api.py               151     14    91%
source_salesforce/source.py             95      9    91%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/rate_limiting.py      22      3    86%
source_salesforce/streams.py           299     42    86%
--------------------------------------------------------
TOTAL                                  585     69    88%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems simple enough.
This seems to imply that there's not a test for the EventWhoRelation steam which would have failed in the previous PR...

@alafanechere
Copy link
Contributor Author

This seems to imply that there's not a test for the EventWhoRelation steam which would have failed in the previous PR...

Yes indeed!

@alafanechere
Copy link
Contributor Author

alafanechere commented Oct 11, 2022

/publish connector=connectors/source-salesforce

🕑 Publishing the following connectors:
connectors/source-salesforce
https://github.com/airbytehq/airbyte/actions/runs/3225978249


Connector Did it publish? Were definitions generated?
connectors/source-salesforce

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@alafanechere
Copy link
Contributor Author

alafanechere commented Oct 11, 2022

/publish connector=connectors/source-salesforce

🕑 Publishing the following connectors:
connectors/source-salesforce
https://github.com/airbytehq/airbyte/actions/runs/3228967740


Connector Did it publish? Were definitions generated?
connectors/source-salesforce

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@alafanechere alafanechere merged commit 1a36074 into master Oct 11, 2022
@alafanechere alafanechere deleted the augustin/source-salesforce/update-unsupported-bulk-api-objects branch October 11, 2022 19:08
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesforce
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants