source-recharge: do not parse json in should_retry
#17822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/documentation
|
/test connector=connectors/source-recharge |
arsenlosenko
approved these changes
Oct 11, 2022
|
/publish connector=connectors/source-recharge
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
/publish connector=connectors/source-recharge
if you have connectors that successfully published but failed definition generation, follow step 4 here |
alafanechere
deleted the
augustin/source-recharge/fix-json-decode-error
branch
This was referenced Oct 13, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix
The
RechargeStreamoverridesshould_retryand was trying to parse JSON response during execution, but recharge responses are not always JSON and this led to the following error:json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0).How
Remove attempt at parsing JSON response.