Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use locally-installed qemu rather than docker-installed version #17848

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Oct 11, 2022

Closes https://github.com/airbytehq/airbyte-cloud/issues/3075.

qemu - process emulation - is needed to build docker images for other chips, like Arm/MacOS M1.

First clue was a recent PR with java connectors base container image change #17820. Reverting it helped for java but python build still fails in the same way - https://github.com/airbytehq/airbyte/actions/runs/3225745475/jobs/5278467317#step:14:4189

Our code line that fails - https://github.com/airbytehq/airbyte/blob/master/tools/integrations/manage.sh#L288

Related moby issue moby/moby#42963 (comment)

@evantahler evantahler marked this pull request as ready for review October 11, 2022 16:02
@evantahler evantahler temporarily deployed to more-secrets October 11, 2022 16:04 Inactive
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 11, 2022
@evantahler
Copy link
Contributor Author

evantahler commented Oct 11, 2022

/test connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/3228417454
✅ connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/3228417454
Python tests coverage:

Name                       Stmts   Miss  Cover
----------------------------------------------
source_faker/__init__.py       2      0   100%
source_faker/source.py       130      2    98%
----------------------------------------------
TOTAL                        132      2    98%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 26 passed, 1 skipped in 30.66s ========================

@evantahler evantahler temporarily deployed to more-secrets October 11, 2022 16:06 Inactive
Co-authored-by: Pedro S. Lopez <pedroslopez@me.com>
@evantahler evantahler temporarily deployed to more-secrets October 11, 2022 16:08 Inactive
@evantahler
Copy link
Contributor Author

evantahler commented Oct 11, 2022

/publish connector=connectors/source-faker

🕑 Publishing the following connectors:
connectors/source-faker
https://github.com/airbytehq/airbyte/actions/runs/3228506443


Connector Did it publish? Were definitions generated?
connectors/source-faker

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@evantahler evantahler merged commit 2d049f1 into master Oct 11, 2022
@evantahler evantahler deleted the evan/fix-m1-publish branch October 11, 2022 17:32
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
…ytehq#17848)

* Use locally-installed qemu rather than docker-installed version

* Bump faker for test

* Update docs/integrations/sources/faker.md

Co-authored-by: Pedro S. Lopez <pedroslopez@me.com>

* auto-bump connector version [ci skip]

Co-authored-by: Pedro S. Lopez <pedroslopez@me.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/faker from/connector-ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants